Rollup of 16 pull requests by JonathanBrouwer · Pull Request #157121 · rust-lang/rust

JonathanBrouwer · 2026-05-29T19:03:38Z

View all comments

Successful merges:

resolve: Partially convert ambiguous_glob_imports lint into a hard error #149195 (resolve: Partially convert ambiguous_glob_imports lint into a hard error)
Some cleanups around passing extra lifetime params from the resolver to ast lowering #156960 (Some cleanups around passing extra lifetime params from the resolver to ast lowering)
definitions: remove DefPathTable, use LocalDefId instead of DefIndex #156963 (definitions: remove DefPathTable, use LocalDefId instead of DefIndex)
Eagerly resolve delegations in late resolution #157053 (Eagerly resolve delegations in late resolution)
NVPTX: Remove the unstable ptx linker flavor #157068 (NVPTX: Remove the unstable ptx linker flavor)
Various proc-macro related code cleanups #157076 (Various proc-macro related code cleanups)
add ABI check logic for wasm #157106 (add ABI check logic for wasm)
std::offload sharedmem #154835 (std::offload sharedmem)
Stabilize Path::is_empty #157065 (Stabilize Path::is_empty)
Improve suggestions for malformed deprecated attribute #157088 (Improve suggestions for malformed deprecated attribute)
Add the clflushopt x86 target feature #157098 (Add the clflushopt x86 target feature)
Add reproducibly failing tests for parallel frontend #157103 (Add reproducibly failing tests for parallel frontend)
Update target maintainer for x86_64-unknown-linux-none #157111 (Update target maintainer for x86_64-unknown-linux-none)
rustc_public: add with_cx() to CompilerInterface #157116 (rustc_public: add with_cx() to CompilerInterface)
ast_lowering: Simplify resolve_pin_drop_sugar_impl_item #157119 (ast_lowering: Simplify resolve_pin_drop_sugar_impl_item)
Cleanups around attribute target checking #157120 (Cleanups around attribute target checking)

Failed merges:

Some more per owner things #157100 (Some more per owner things)

r? @ghost

Create a similar rollup

…d named lifetimes

… so just encode the fields we need

This makes the proc-macro RPC protocol platform independent as necessary for running proc macros and rustc on different architectures.

This shrinks the proc-macro ABI a bit. Nothing on the client side needs to allocate handles. This will share the counters between proc-macros, which may cause us to run out of handles earlier, but 4 bilion handles per process is still a lot. Rust-analyzer might run out at some point, but it can recover by restarting the proc-macro-server, and it could already run out before this change anyway,

…s version shaped

`CLFLUSHOPT` is a standalone x86 CPUID feature (Intel Skylake+ / AMD Excavator+, ~2015) not part of any psABI microarchitecture level, so it needs its own unstable target feature, gated behind `clflushopt_target_feature`. This is the compiler half of exposing the `_mm_clflushopt` intrinsic; the stdarch half is blocked on this landing. Also bless two UI test references (check-cfg/target_feature and target-feature/invalid-attribute) that enumerate the full set of valid target features, since `clflushopt` is now part of that list.

Wire up runtime detection for the `clflushopt` feature: add it to the `is_x86_feature_detected!` feature list (gated on `clflushopt_target_feature`), enable it from CPUID leaf 7 EBX bit 23, and add it to the std_detect x86-specific dump test.

…sible

…error

rust-bors · 2026-05-29T23:17:17Z

💔 Test for c24e9c9 failed: CI. Failed job:

auto - dist-x86_64-musl (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-05-29T23:31:48Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

================================================================================

/mnt is not a mountpoint
Unable to correct missing packages.
E: Failed to fetch mirror+file:/etc/apt/apt-mirrors.txt/pool/main/o/openjdk-21/openjdk-21-jre-headless_21.0.10%2b7-1%7e24.04_amd64.deb  404  Not Found [IP: 52.252.163.49 80]
E: Unable to correct problems, you have held broken packages.
E: Aborting install.
##[error]Process completed with exit code 100.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h

rust-bors · 2026-05-30T01:00:08Z

☀️ Try build successful (CI)
Build commit: cf6402b (cf6402b36d88a1157ff52ee82a5352be7718c3d1, parent: 6368fd52cb9f230dfb156097625993e7a8891800)

JonathanBrouwer · 2026-05-30T03:49:23Z

@bors retry

rust-bors · 2026-05-30T07:05:19Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 15m 20s
Pushing 6eda741 to main...

github-actions · 2026-05-30T07:08:45Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6368fd5 (parent) -> 6eda741 (this PR)

Test differences

Show 257 test diffs

Stage 1

[assembly] tests/assembly-llvm/nvptx-arch-link-arg.rs: ignore (only executed when the architecture is nvptx64) -> [missing] (J1)
[ui] tests/ui/feature-gates/feature-gate-clflushopt_target_feature.rs: [missing] -> pass (J1)
[ui] tests/ui/imports/ambiguous-2.rs: pass -> [missing] (J1)
[ui] tests/ui/imports/ambiguous-4.rs: pass -> [missing] (J1)
[ui] tests/ui/linkage-attr/unstable-flavor.rs#llbc: [missing] -> pass (J1)
[ui] tests/ui/linkage-attr/unstable-flavor.rs#ptx: pass -> [missing] (J1)

Stage 2

[ui] tests/ui/imports/ambiguous-2.rs: pass -> [missing] (J0)
[ui] tests/ui/imports/ambiguous-4.rs: pass -> [missing] (J0)
[ui] tests/ui/linkage-attr/unstable-flavor.rs#llbc: [missing] -> pass (J0)
[ui] tests/ui/linkage-attr/unstable-flavor.rs#ptx: pass -> [missing] (J0)
[ui] tests/ui/feature-gates/feature-gate-clflushopt_target_feature.rs: [missing] -> ignore (only executed when the architecture is x86_64) (J2)
[ui] tests/ui/feature-gates/feature-gate-clflushopt_target_feature.rs: [missing] -> pass (J3)
[assembly] tests/assembly-llvm/nvptx-arch-link-arg.rs: ignore (only executed when the architecture is nvptx64) -> [missing] (J4)

Additionally, 244 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 6eda7419e71fdbc1185ed5be7e6bff1a474ab5cd --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-gnu-gcc-core-tests: 7m 44s -> 14m 17s (+84.6%)
x86_64-gnu-llvm-21-1: 32m 6s -> 55m 37s (+73.3%)
x86_64-gnu-gcc: 48m 25s -> 1h 8m (+41.7%)
x86_64-msvc-2: 2h 29m -> 1h 27m (-41.3%)
x86_64-gnu-tools: 45m 35s -> 1h 3m (+38.8%)
arm-android: 1h 17m -> 1h 47m (+37.6%)
dist-loongarch64-linux: 1h 54m -> 1h 14m (-34.8%)
x86_64-msvc-1: 2h -> 2h 38m (+31.2%)
x86_64-msvc-ext2: 2h -> 1h 28m (-27.0%)
x86_64-gnu-nopt: 2h 29m -> 1h 51m (-25.4%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-05-30T07:10:02Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#149195	resolve: Partially convert `ambiguous_glob_imports` lint in…	`fd72a96537514dab33f38bb8e7af2582577fad64` (link)
#154835	std::offload sharedmem	`9e7f589cdbe2dca43a72f279055bc380d5b83bc2` (link)
#156960	Some cleanups around passing extra lifetime params from the…	`5310660ea6aba530820808e5cf48d6c10f2e0214` (link)
#156963	definitions: remove `DefPathTable`, use `LocalDefId` instea…	`194b9b6a3fdf762ee839f33f2d9f374c5e0ca81a` (link)
#157053	Eagerly resolve delegations in late resolution	`ae753774ec441f7e5602ec3bd67a2de1a432ee77` (link)
#157065	Stabilize `Path::is_empty`	`d10093844c48285c46fdef1fc8f31af9e1052620` (link)
#157068	NVPTX: Remove the unstable ptx linker flavor	`293c4a3dc7172ec8dc9ad04449f739d31bcfd8b0` (link)
#157076	Various proc-macro related code cleanups	`ee8631452e2bcf745c69c9a132bd6e696f8be287` (link)
#157088	Improve suggestions for malformed deprecated attribute	`5514fc67e6544c33947338418891805729ebb42f` (link)
#157098	Add the `clflushopt` x86 target feature	`7ece98429d01b9c81196701a9e4cb7f915c7cc5d` (link)
#157103	Add reproducibly failing tests for parallel frontend	`cf9529c0164929944b5a0ba6090515ecc1becfd7` (link)
#157106	add ABI check logic for wasm	`97fa63497660e600e90e3f178f47845d7dd7fd96` (link)
#157111	Update target maintainer for x86_64-unknown-linux-none	`9830da861e35ea78d7e28f9aba77c40d65db712a` (link)
#157116	rustc_public: add `with_cx()` to `CompilerInterface`	`3a122e37ac026d986dca818e44494a530f2cc60d` (link)
#157119	ast_lowering: Simplify `resolve_pin_drop_sugar_impl_item`	`2bc707ad1c62fa825dc69b0304d0b679e0ba3c24` (link)
#157120	Cleanups around attribute target checking	`2dfaa91aeb5270528fa1e365eac60a05afe68764` (link)

previous master: 6368fd52cb

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2026-05-30T07:46:47Z

Finished benchmarking commit (6eda741): comparison URL.

Overall result: ❌✅ regressions and improvements - BENCHMARK(S) FAILED

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

❗ ❗ ❗ ❗ ❗
Warning ⚠️: The following benchmark(s) failed to build:

runtime:css

❗ ❗ ❗ ❗ ❗

cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.6%	[0.3%, 1.0%]	9
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.2%, -0.1%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -1.3%, secondary -0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.1%	[3.1%, 3.1%]	1
Improvements ✅ (primary)	-1.3%	[-2.2%, -0.8%]	3
Improvements ✅ (secondary)	-1.8%	[-2.7%, -1.0%]	2
All ❌✅ (primary)	-1.3%	[-2.2%, -0.8%]	3

Cycles

Results (primary 2.2%, secondary 7.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.2%	[2.2%, 2.2%]	1
Regressions ❌ (secondary)	7.1%	[7.1%, 7.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.2%	[2.2%, 2.2%]	1

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	7
All ❌✅ (primary)	-	-	0

Bootstrap: 511.654s -> 518.609s (1.36%)
Artifact size: 400.70 MiB -> 400.72 MiB (0.01%)

JonathanBrouwer · 2026-05-30T09:11:28Z

The failed benchmark is caused by #149195 (comment)

oli-obk and others added 30 commits May 26, 2026 09:54

Merge two functions always called after each other

685984a

Remove an unnecessary generic

ed8e3ba

Add a dedicated method for error lifetime recording

31a054c

Rename and document some methods

d8cddda

Drop an unused distinction (in diagnostics code) between anonymous an…

bf5045c

…d named lifetimes

Remove some dead code

c0819ff

Remove an unused field

87f9c4f

extra_lifetime_params_map can only ever contain LifetimeRes::Fresh,…

19a5af7

… so just encode the fields we need

Stabilize Path::is_empty

c8aba3e

Remove a hack introduced back when unwinding through extern "C" was UB

420566f

Implement Encode and Decode for proc_macro::TokenStream wrapper type

32615f2

Remove outdated comment

53b4acd

Remove unused proc_macro table from crate metadata

5c56e61

Use platform independent encoding for integers in proc-macro RPC

bde798a

This makes the proc-macro RPC protocol platform independent as necessary for running proc macros and rustc on different architectures.

Give variables passed to Omp/Offload nice names on LLVM-IR level

fade967

Enable requesting shared-memory at kernel launch-time via offload

c01bfdc

Suggest using NameValue syntax for malformed deprecated attribute

a1d4ad1

Suggest using since field when malformed deprecated attribute value i…

9bfbf34

…s version shaped

Eagerly resolve delegations in late resolution

942ac85

Update reproducibly failing tests when parallel frontend is enabled

f582193

NVPTX: Remove the deprecated ptx linker flavor

ec46eac

Add feature-gate test for clflushopt_target_feature

0980491

add ABI check logic for wasm

2c0f9de

Remove DefPathTable, use LocalDefId instead of DefIndex where pos…

7767295

…sible

Update target maintainer for x86_64-unknown-linux-none

7d9aab6

resolve: Partially convert ambiguous_glob_imports lint into a hard …

15b1398

…error

rustc_public: add with_cx() to CompilerInterface

f6cbfd9

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 29, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 30, 2026

rust-bors Bot merged commit 6eda741 into rust-lang:main May 30, 2026
4 of 14 checks passed

rustbot added this to the 1.98.0 milestone May 30, 2026

This was referenced May 30, 2026

Some more per owner things #157100

Merged

Rollup of 9 pull requests #157142

Closed

rustbot added the perf-regression Performance regression. label May 30, 2026

JonathanBrouwer mentioned this pull request May 30, 2026

resolve: Partially convert ambiguous_glob_imports lint into a hard error #149195

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 16 pull requests#157121

Rollup of 16 pull requests#157121
rust-bors[bot] merged 49 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-htRw3jp

JonathanBrouwer commented May 29, 2026 •

edited by rustbot

Loading

Uh oh!

rust-bors Bot commented May 29, 2026

Uh oh!

rust-log-analyzer commented May 29, 2026

Uh oh!

rust-bors Bot commented May 30, 2026

Uh oh!

JonathanBrouwer commented May 30, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented May 30, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 30, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented May 30, 2026

Uh oh!

rust-timer commented May 30, 2026

Uh oh!

JonathanBrouwer commented May 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Uh oh!

Conversation

JonathanBrouwer commented May 29, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors Bot commented May 29, 2026

Uh oh!

rust-log-analyzer commented May 29, 2026

Uh oh!

rust-bors Bot commented May 30, 2026

Uh oh!

JonathanBrouwer commented May 30, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented May 30, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 30, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented May 30, 2026

Uh oh!

rust-timer commented May 30, 2026

Overall result: ❌✅ regressions and improvements - BENCHMARK(S) FAILED

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

JonathanBrouwer commented May 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

JonathanBrouwer commented May 29, 2026 •

edited by rustbot

Loading